nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From trkurc <...@git.apache.org>
Subject [GitHub] nifi pull request: NIFI-748 Fixed logic around handling partial qu...
Date Sun, 15 Nov 2015 14:29:59 GMT
Github user trkurc commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/123#discussion_r44872470
  
    --- Diff: nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/lucene/LuceneUtil.java
---
    @@ -160,4 +162,25 @@ public int compare(final Document o1, final Document o2) {
                 }
             });
         }
    +
    +    /**
    +     * Will group documents based on the {@link FieldNames#STORAGE_FILENAME}.
    +     *
    +     * @param documents
    +     *            list of {@link Document}s
    +     * @return a {@link Map} of document groups with
    +     *         {@link FieldNames#STORAGE_FILENAME} as key and {@link List} of
    +     *         {@link Document}s as value.
    +     */
    +    public static Map<String, List<Document>> groupDocsByStorageFileName(final
List<Document> documents) {
    --- End diff --
    
    I like this change. It greatly simplifies the code 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message