nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From apiri <...@git.apache.org>
Subject [GitHub] nifi pull request: NIFI-748 Fixed logic around handling partial qu...
Date Sun, 15 Nov 2015 16:56:33 GMT
Github user apiri commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/123#discussion_r44874262
  
    --- Diff: nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/lucene/DocsReader.java
---
    @@ -47,9 +46,6 @@
     public class DocsReader {
         private final Logger logger = LoggerFactory.getLogger(DocsReader.class);
     
    -    public DocsReader(final List<File> storageDirectories) {
    -    }
    -
    --- End diff --
    
    I think there has been a "handshake agreement" on the nature of the framework code versus
the extension developer facing API.  Having said that, I was not able to find any documentation
that indicates that is the case.  As a result, I think I am a similar 95/5 split as Tony.
 As a result, I think the "right" thing given the circumstances is to tag it up as Deprecated
and remove at 1.x.  However, I think it's likely a fair assumption that this is clear.  Either
way, we need to get the handshake agreement in a tangible form some place.  I'll make a ticket
and please add on/enhance as needed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message