nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From olegz <...@git.apache.org>
Subject [GitHub] nifi pull request: NIFI-748 Fixed logic around handling partial qu...
Date Mon, 16 Nov 2015 13:43:49 GMT
Github user olegz commented on the pull request:

    https://github.com/apache/nifi/pull/123#issuecomment-157029989
  
    @trkurc @joewitt @apiri 
    Guys, please see the latest commit. Didn't squash it, so its easier to read and see what's
been addressed. In summary:
    1. Since based on the latest comment from Joe it appears that we all agree that DocReader
is not really public, i kept the dead constructor out and also made DocReader package private.
    2. Based on Tony's point added Document sorting logic back. At least it will ensure that
previous behavior is maintained. 
    See commit message for more details  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message