nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From apiri <...@git.apache.org>
Subject [GitHub] nifi pull request: NIFI-1123 Adds expression language support to D...
Date Tue, 17 Nov 2015 17:48:39 GMT
Github user apiri commented on the pull request:

    https://github.com/apache/nifi/pull/116#issuecomment-157450706
  
    Was combing through the actual PR.  Not sure I am onboard with the additional property
and misunderstood what the intent was.  There was a similar effort with the Character Set
Validator where we validated that the specified charset was valid if specified, otherwise
just that a string was returned via EL should it be an expression.
    
    Regex Validator, by default evaluates the EL and then applies validation to the resulting
"regex".  Would it be reasonable to have a separate validator that matches the semantics of
what you are looking for (akin to that of how ConvertCharacterSet functions)?  Should be okay
from the standpoint of compatibility and non-breaking changes.
    
    Additionally, playing with this a bit, I did a blanket delete (.*) which leads to some
bad effects in terms of the framework as the UUID is removed and puts us in a bad state.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message