nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jskora <...@git.apache.org>
Subject [GitHub] nifi pull request: NIFI-1123 Adds expression language support to D...
Date Tue, 17 Nov 2015 19:44:21 GMT
Github user jskora commented on the pull request:

    https://github.com/apache/nifi/pull/116#issuecomment-157484556
  
    @apiri, the property value is compiled as a regex, any separators are in the context of
the regex.  
    
    I'm not sure I understand how the RegexValidator can evaluate the EL since it could refer
to dynamic attributes?  If the validator works, won't the UI prevent the processor from being
started with the bad values like those in @trkurc's tests?  And won't the tests fail to run
the processor since it is invalid?  If that's the case, the invalid values will never be used.
    
    Regarding the deletion of framework attributes, should UpdateAttributes prevent their
deletion or should the ProcessSession sub-classes prevent that more globally?  What framework
attributes should be protected, is it everything in CoreAttributes?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message