nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From apiri <...@git.apache.org>
Subject [GitHub] nifi pull request: NIFI-1123 Adds expression language support to D...
Date Tue, 17 Nov 2015 20:21:58 GMT
Github user apiri commented on the pull request:

    https://github.com/apache/nifi/pull/116#issuecomment-157495716
  
    @jskora Sorry, I think a few of the different contexts from messages between you, @trkurc
and I made communication a bit jumbled.
    
    To that end, I am onboard with regex, but personally, would not want a second field to
the same focus.  The issue that is present is more of an issue with the underlying framework
and its handling with EL.  What I was suggesting with the regex validator is applying the
validation to an entered string, but bypassing validation for where these values are specified
on a per FlowFile basis via EL.  What is missing is not so much the granularity as it is the
ability to route failures which is currently nonexistent and was some of what @trkurc was
asking about what the appropriate tradeoffs/concessions are given the current state of the
framework.  To this idea, I am more for keeping consistent with how we are now and letting
this get addressed with the needed framework adjustments as we move forward.
    
    To your question regarding deletion, that is certainly not on you or any extension developer.
 As highlighted by NIFI-1181/1182, these values are safeguarded but your processor exposed
the bug of where it was not safeguarded in this context.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message