nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tony Kurc <trk...@gmail.com>
Subject Re: ExecuteStreamCommand tests
Date Thu, 12 Nov 2015 22:32:06 GMT
Do you plan to undo the removal?
On Nov 12, 2015 4:46 PM, "Joe Witt" <joe.witt@gmail.com> wrote:

> well that explains these goofball classes I deleted the other day
>
> https://issues.apache.org/jira/browse/NIFI-1134
>
> These classes were used to make those Jars.  Those jars are used to
> test execute command.  We've now removed the source that was floating
> randomly.  We need the built to automatically create whatever we
> execute against if we're going to do this.  Those tests should be
> replaced by something else.
>
>
> On Thu, Nov 12, 2015 at 3:02 PM, Joe Percivall
> <joepercivall@yahoo.com.invalid> wrote:
> > Tony,
> >
> > I did a bit of digging through the history and the jars were a part of
> the initial code import so unless if Joe or someone else knows where they
> came from then we may be out of luck.
> >
> > Joe
> >
> > - - - - - -
> > Joseph Percivall
> > linkedin.com/in/Percivall
> > e: joepercivall@yahoo.com
> >
> >
> >
> >
> > On Wednesday, November 11, 2015 6:23 PM, Tony Kurc <trkurc@gmail.com>
> wrote:
> >
> >
> >
> > All, I was code reviewing and something occurred to me. This raised my
> > eyebrow:
> >
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestExecuteStreamCommand.java#L63
> >
> > If I'm reading it right, the test "runs" a jar that we've got in our
> source
> > tree
> >
> > What code made those jars in src/test/resources?
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message