nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Witt <joe.w...@gmail.com>
Subject Re: PRs
Date Wed, 25 Nov 2015 03:29:36 GMT
understood - thanks.

On Tue, Nov 24, 2015 at 10:28 PM, Tony Kurc <trkurc@gmail.com> wrote:
> Joe - I reviewed NIFI-1107 when it was a processor on its own
> (PutS3Multipart) and have an S3 testbed set up. I'm working through it now.
> I believe Joe S. has been stress testing it as well. The good news is that
> the code path for small files to S3 is largely unmolested, so it is not as
> high risk as you might think.
>
> On Tue, Nov 24, 2015 at 10:23 PM, Joe Witt <joe.witt@gmail.com> wrote:
>
>> Given the testing to NIFI-1192 and review of NIFI-631 done already
>> both are lower risk I think.
>>
>> NIFI-1107 seems very useful and helpful but we do need to be careful
>> given that we know this one is already in use and this is a
>> substantive change.
>>
>> If there are folks that can dig into review/testing of NIFI-1107 that
>> would be great.  Waiting for word on NIFI-655 readiness then I think
>> we should go cold and just focus on testing an RC.
>>
>> Thanks
>> Joe
>>
>> On Tue, Nov 24, 2015 at 4:22 PM, Tony Kurc <trkurc@gmail.com> wrote:
>> > Agreed. I know there has already been a good deal of discussion about
>> > design on all these.
>> >
>> > On Tue, Nov 24, 2015 at 4:14 PM, Aldrin Piri <aldrinpiri@gmail.com>
>> wrote:
>> >
>> >> No qualms here.  If they look good to go while the work and testing
>> >> surrounding NIFI-655 wraps up, they might as well be included. Would not
>> >> want to delay the release should any of these become protracted in
>> terms of
>> >> iterations.
>> >>
>> >> On Tue, Nov 24, 2015 at 4:05 PM, Tony Kurc <trkurc@gmail.com> wrote:
>> >>
>> >> > All,
>> >> > I was reviewing github PRs and wondering whether anyone objected to
>> >> > slipping a couple that look like they're very close into 0.4.0.
>> >> >
>> >> > NIFI-1192 (#131)
>> >> > NIFI-631 (#113)
>> >> > NIFI-1107 (#192)
>> >> >
>> >> > I should have some review cycles tonight. Lots of comments on them
>> all,
>> >> and
>> >> > have good "momentum".
>> >> >
>> >> > Tony
>> >> >
>> >>
>>

Mime
View raw message