nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From markap14 <...@git.apache.org>
Subject [GitHub] nifi pull request: NIFI-1417 Exposing several connection settings ...
Date Mon, 01 Feb 2016 20:48:47 GMT
Github user markap14 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/194#discussion_r51478213
  
    --- Diff: nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/SolrProcessor.java
---
    @@ -120,6 +202,22 @@ protected final SolrClient getSolrClient() {
                             .explanation("A collection must specified for Solr Type of Cloud")
                             .build());
                 }
    +
    +            if (!context.getProperty(ZK_CLIENT_TIMEOUT).isSet()) {
    +                problems.add(new ValidationResult.Builder()
    +                        .subject(ZK_CLIENT_TIMEOUT.getName())
    +                        .valid(false)
    +                        .explanation("A ZooKeeper Client Timeout must specified for Solr
Type of Cloud")
    +                        .build());
    +            }
    +
    +            if (!context.getProperty(ZK_CONNECTION_TIMEOUT).isSet()) {
    --- End diff --
    
    This is 'dead code' as isSet() will always return 'true', since there is a defaultValue


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message