nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From markap14 <...@git.apache.org>
Subject [GitHub] nifi pull request: NIFI-865 added initial support for AMQP publish...
Date Tue, 02 Feb 2016 17:15:29 GMT
Github user markap14 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/200#discussion_r51600649
  
    --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AMQPWorker.java
---
    @@ -0,0 +1,104 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.amqp.processors;
    +
    +import java.io.IOException;
    +
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import com.rabbitmq.client.Channel;
    +import com.rabbitmq.client.Connection;
    +
    +/**
    + * Base class for implementing publishing and consuming AMQP workers.
    + *
    + * @see AMQPPublisher
    + * @see AMQPConsumer
    + */
    +abstract class AMQPWorker implements AutoCloseable {
    +
    +    private final static Logger logger = LoggerFactory.getLogger(AMQPWorker.class);
    +
    +    protected final Channel channel;
    +
    +    /**
    +     * Creates an instance of this worker initializing it with AMQP
    +     * {@link Connection} and creating a target {@link Channel} used by
    +     * sub-classes to interruct with AMQP-based messaging system.
    +     *
    +     * @param connection
    +     *            instance of {@link Connection}
    +     */
    +    public AMQPWorker(Connection connection) {
    +        this.validateConnection(connection);
    +        try {
    +            this.channel = connection.createChannel();
    +        } catch (IOException e) {
    +            logger.error("Failed to create Channel for " + connection, e);
    +            throw new IllegalStateException(e);
    +        }
    +    }
    +
    +    /**
    +     * Closes {@link Channel} created when instance of this class was created.
    +     */
    +    @Override
    +    public void close() throws Exception {
    --- End diff --
    
    channel.close() will only ever throw IOException (at least that's the only checked exception
that it will throw) - should close() declare to throw only IOException instead of the general
Exception:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message