nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From trkurc <...@git.apache.org>
Subject [GitHub] nifi pull request: NIFI-1513: fixed some easy to fix errors
Date Sun, 14 Feb 2016 03:42:55 GMT
Github user trkurc commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/221#discussion_r52837465
  
    --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GetHTTP.java
---
    @@ -426,60 +423,65 @@ public void onTrigger(final ProcessContext context, final ProcessSessionFactory
                 if (accept != null) {
                     get.addHeader(HEADER_ACCEPT, accept);
                 }
    +            // create the http client
    +            try ( final CloseableHttpClient client = clientBuilder.build() ) {
    +                // NOTE: including this inner try in order to swallow exceptions on close
    +                try {
    --- End diff --
    
    Holy smokes, this got butchered, it should just be an indentation of that try block


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message