nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From olegz <...@git.apache.org>
Subject [GitHub] nifi pull request: NIFI-1464, NIFI-78, NIFI-1487 Refactored Proces...
Date Mon, 15 Feb 2016 14:54:40 GMT
Github user olegz commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/210#discussion_r52907459
  
    --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/java/org/apache/nifi/controller/service/TestStandardControllerServiceProvider.java
---
    @@ -218,7 +221,7 @@ public void testStartStopReferencingComponents() {
                 public Object answer(InvocationOnMock invocation) throws Throwable {
                     final ProcessorNode procNode = (ProcessorNode) invocation.getArguments()[0];
                     procNode.verifyCanStart();
    -                procNode.setScheduledState(ScheduledState.RUNNING);
    +                // procNode.setScheduledState(ScheduledState.RUNNING);
    --- End diff --
    
    True, and I think this test(s) may need to be removed since tests that I added as part
of the refactoring efforts cover all possible scenarios without Mocks. And if for some reason
you'll find a missing scenario, let me know and I'll add a test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message