nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From markap14 <...@git.apache.org>
Subject [GitHub] nifi pull request: NIFI-1464, NIFI-78, NIFI-1487 Refactored Proces...
Date Tue, 16 Feb 2016 17:15:53 GMT
Github user markap14 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/210#discussion_r53043617
  
    --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/service/StandardControllerServiceProvider.java
---
    @@ -457,6 +457,7 @@ public ControllerServiceNode getControllerServiceNode(final String
serviceIdenti
         public Set<String> getControllerServiceIdentifiers(final Class<? extends
ControllerService> serviceType) {
             final Set<String> identifiers = new HashSet<>();
             for (final Map.Entry<String, ControllerServiceNode> entry : controllerServices.entrySet())
{
    +            Class<? extends ControllerService> c = entry.getValue().getProxiedControllerService().getClass();
    --- End diff --
    
    I don't understand why this line was added. Was the intent to reference 'c' below, rather
than having that expression inline?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message