nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From apiri <...@git.apache.org>
Subject [GitHub] nifi pull request: Added support for using proxy for aws processor...
Date Tue, 16 Feb 2016 17:24:35 GMT
Github user apiri commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/209#discussion_r53044987
  
    --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/AbstractAWSProcessor.java
---
    @@ -91,6 +93,23 @@
                 .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
                 .sensitive(true)
                 .build();
    +
    +    public static final PropertyDescriptor PROXY_HOST = new PropertyDescriptor.Builder()
    +            .name("Proxy Host")
    +            .description("Proxy host name or ip")
    +            .expressionLanguageSupported(true)
    +            .required(false)
    +            .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
    +            .build();
    +
    +    public static final PropertyDescriptor PROXY_HOST_PORT = new PropertyDescriptor.Builder()
    +            .name("Proxy Host Port")
    +            .description("Proxy host port (must be postive integer)")
    +            .expressionLanguageSupported(true)
    +            .required(false)
    +            .addValidator(StandardValidators.POSITIVE_INTEGER_VALIDATOR)
    --- End diff --
    
    @mans2singh One quick note, do you mind if I convert this validator to the StandardValidators.PORT_VALIDATOR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message