nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mattyb149 <...@git.apache.org>
Subject [GitHub] nifi pull request: NIFI-1594: Add option to bulk using Index or Up...
Date Sat, 05 Mar 2016 01:49:12 GMT
Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/255#discussion_r55112614
  
    --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearch.java
---
    @@ -99,6 +99,14 @@
                         AttributeExpression.ResultType.STRING, true))
                 .build();
     
    +    public static final PropertyDescriptor INDEX_OP = new PropertyDescriptor.Builder()
    +            .name("Index Operation")
    +            .description("The type of the operation used to index (index, update, upsert)")
    --- End diff --
    
    The description mentions three modes but only two are allowed. Should they be "insert"
and "update/upsert", or is "index" the preferred terminology for adding a new document?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message