nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mans2singh <...@git.apache.org>
Subject [GitHub] nifi pull request: Nifi 1516 - AWS DynamoDB Get/Put/Delete Process...
Date Sun, 06 Mar 2016 21:04:32 GMT
Github user mans2singh commented on the pull request:

    https://github.com/apache/nifi/pull/224#issuecomment-192992232
  
    @jvwing - Thanks or your feedback.  
    
    Based on your recommendations - I've added separate relations for  unprocessed and not
found (latter only for get dynamo processor).  I've also added unit test cases for not found
and updated integration/unit tests for unprocessed scenarios for all the processors.  While
adding unit test cases for not found a bug which was hiding the error in a failure and I've
corrected that.  
    I've also refactored the handle unprocessed items to keep only the common code between
delete and put processors in the AbstractWriteDynamoDBProcessor.
    Please let me know if you have any other recommendations.
    Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message