nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From markap14 <...@git.apache.org>
Subject [GitHub] nifi pull request: NIFI-1552: Define Authorizer API
Date Fri, 01 Apr 2016 19:07:17 GMT
Github user markap14 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/318#discussion_r58252888
  
    --- Diff: nifi-api/src/main/java/org/apache/nifi/authorization/AuthorizationRequest.java
---
    @@ -0,0 +1,130 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.authorization;
    +
    +import java.util.Map;
    +import java.util.Objects;
    +
    +/**
    + * Represents an authorization request for a given user/entity performing an action against
a resource within some context.
    + */
    +public class AuthorizationRequest {
    +
    +    private final Resource resource;
    +    private final String identity;
    +    private final RequestAction action;
    +    private final Map<String, String> context;
    +    private final Map<String, String> eventAttributes;
    +
    +    public AuthorizationRequest(final Builder builder) {
    +        Objects.requireNonNull(builder.resource, "The resource is required when creating
an authorization request");
    +        Objects.requireNonNull(builder.identity, "The identity of the user is required
when creating an authorization request");
    +        Objects.requireNonNull(builder.action, "The action is required when creating
an authorization request");
    +
    +        this.resource = builder.resource;
    +        this.identity = builder.identity;
    +        this.action = builder.action;
    +        this.context = builder.context;
    --- End diff --
    
    These maps should probably be wrapped in Unmodifiable Maps, since they will be returned
below in the getters


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message