nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From markap14 <...@git.apache.org>
Subject [GitHub] nifi pull request: NIFI-1552: Define Authorizer API
Date Fri, 01 Apr 2016 19:09:12 GMT
Github user markap14 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/318#discussion_r58253202
  
    --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-administration/src/main/java/org/apache/nifi/authorization/StandardAuthorizerConfigurationContext.java
---
    @@ -0,0 +1,50 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.authorization;
    +
    +import java.util.Collections;
    +import java.util.Map;
    +
    +/**
    + *
    + */
    +public class StandardAuthorizerConfigurationContext implements AuthorizerConfigurationContext
{
    +
    +    private final String identifier;
    +    private final Map<String, String> properties;
    +
    +    public StandardAuthorizerConfigurationContext(String identifier, Map<String, String>
properties) {
    +        this.identifier = identifier;
    +        this.properties = properties;
    --- End diff --
    
    This should probably be a copy of the map stored here, no? May also make sense to do something
like:
    this.properties = Collections.unmodifiableMap(new HashMap<>(properties));
    This way, we don't have to create a new Map object each time that getProperties() is called.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message