nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From apiri <...@git.apache.org>
Subject [GitHub] nifi-minifi pull request: MINIFI-15 Created a config file format w...
Date Fri, 15 Apr 2016 19:08:36 GMT
Github user apiri commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi/pull/8#discussion_r59925817
  
    --- Diff: minifi-nar-bundles/minifi-framework-bundle/minifi-framework/minifi-resources/src/main/resources/conf/config.yml
---
    @@ -0,0 +1,101 @@
    +# Licensed to the Apache Software Foundation (ASF) under one or more
    +# contributor license agreements.  See the NOTICE file distributed with
    +# this work for additional information regarding copyright ownership.
    +# The ASF licenses this file to You under the Apache License, Version 2.0
    +# (the \"License\"); you may not use this file except in compliance with
    +# the License.  You may obtain a copy of the License at
    +#
    +#     http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing, software
    +# distributed under the License is distributed on an \"AS IS\" BASIS,
    +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +# See the License for the specific language governing permissions and
    +# limitations under the License.
    +
    +Flow Controller:
    --- End diff --
    
    Overall this looks good.  I think a few of the items that are more tailored toward the
UI may be on the chopping block moving forward.  name/comment and their ilk could probably
be hidden from this config.  Not saying a change is needed now, just wanted to make a note.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message