nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From apiri <...@git.apache.org>
Subject [GitHub] nifi-minifi pull request: MINIFI-12 initial commit of http config ...
Date Sat, 16 Apr 2016 03:59:58 GMT
Github user apiri commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi/pull/9#discussion_r59961984
  
    --- Diff: minifi-nar-bundles/minifi-framework-bundle/minifi-framework/minifi-runtime/pom.xml
---
    @@ -40,6 +40,24 @@ limitations under the License.
                 <groupId>org.apache.nifi.minifi</groupId>
                 <artifactId>minifi-api</artifactId>
             </dependency>
    +        <dependency>
    +            <groupId>ro.pippo</groupId>
    +            <artifactId>pippo-core</artifactId>
    +        </dependency>
    +        <dependency>
    +            <groupId>ro.pippo</groupId>
    +            <artifactId>pippo-tomcat</artifactId>
    --- End diff --
    
    Was there a reason that Tomcat was chosen over some of the other alternatives?  No strong
objection to Tomcat, but know that Jetty is used elsewhere.
    
    pippo-core looks clear, but pippo-tomcat looks like it will need the LICENSE/NOTICE files
updated as Tomcat seems to bring in a fair number of items 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message