nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JPercivall <...@git.apache.org>
Subject [GitHub] nifi issue #349: NIFI-1767 AWS IoT processors
Date Wed, 01 Jun 2016 17:18:38 GMT
Github user JPercivall commented on the issue:

    https://github.com/apache/nifi/pull/349
  
    A bit nit picky and I may be alone here, but I find putting "if" statements and their
content on the same line a bit hard to read when trying to read someone else's code. For example
line 107 of GetAWSIoT[1]. When reviewing it's nice to distinctly see "if" statements condition
and content. 
    
    I would prefer the bit more verbose but easier consume longer format:
    `if (awsQos == 0) {
        mqttClient.unsubscribe(awsTopic);
    }'
    
    [1] https://github.com/apache/nifi/blob/d46b01c7edf9089a944c3fc1c71b046cd19a04c2/nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/GetAWSIoT.java#L107-L107


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message