nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Witt <joe.w...@gmail.com>
Subject Re: [EXT] Using github to merge PRs and just generally easier tracking of commits..
Date Tue, 05 Jan 2021 18:02:09 GMT
I dont know if you can tweak the message in github before hitting the
button as a reviewer.

Now that I see how to tell who merged though in any case Im less concerned
personally.



On Tue, Jan 5, 2021 at 10:56 AM Peter Wicks (pwicks) <pwicks@micron.com>
wrote:

> Should mergers be putting the “signed-off by: …” in when they Merge PR’s
> through Github?
> I haven’t merged anything in a while, but I was putting this in the
> comment box when I merged, and it showed up on the commit the same way it
> did when I did it through the CLI:
>
> https://github.com/apache/nifi/commit/f1d35f46cede60401190777d55350439af106ba7
>
> As for signing merges, yeah, that’s unfortunate that GitHub doesn’t seem
> to support that.
>
> From: Joe Witt <joe.witt@gmail.com>
> Date: Monday, January 4, 2021 at 12:48 PM
> To: dev@nifi.apache.org <dev@nifi.apache.org>
> Subject: [EXT] Using github to merge PRs and just generally easier
> tracking of commits..
> CAUTION: EXTERNAL EMAIL. Do not click links or open attachments unless you
> recognize the sender and were expecting this message.
>
>
> Team,
>
> If you merge PRs from Github they will not do the 'signed off by' and the
> commits are not verified.  That said the convenience is hard to argue and
> obviously we need to do a better job of getting PRs processed in a
> timely fashion.  So if you want an easier way to see not only who authored
> a commit but also who actually merged it (the committer) then you can run
>
> git log --pretty=fuller
>
> That gives output like
>
> commit e7c6bdad42514200d8732b644c59dcb789e358da (HEAD -> main,
> upstream/main, github/main)
> Author:     exceptionfactory <exceptionfactory@gmail.com>
> AuthorDate: Sat Oct 17 12:25:00 2020 -0400
> Commit:     markap14 <markap14@hotmail.com>
> CommitDate: Mon Jan 4 14:20:05 2021 -0500
>
>     NIFI-7937 Added StandardFlowFileMediaType enum to replace string
> references to FlowFile Media Types
>
>
>
> This is nice as it shows both who made the PR, who merged the PR, when the
> PR was offered vs merged, etc.  And that works even if the commit
> wasnt signed/signed off.
>
> Thanks
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message