nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Witt <joe.w...@gmail.com>
Subject Using github to merge PRs and just generally easier tracking of commits..
Date Mon, 04 Jan 2021 19:47:37 GMT
Team,

If you merge PRs from Github they will not do the 'signed off by' and the
commits are not verified.  That said the convenience is hard to argue and
obviously we need to do a better job of getting PRs processed in a
timely fashion.  So if you want an easier way to see not only who authored
a commit but also who actually merged it (the committer) then you can run

git log --pretty=fuller

That gives output like

commit e7c6bdad42514200d8732b644c59dcb789e358da (HEAD -> main,
upstream/main, github/main)
Author:     exceptionfactory <exceptionfactory@gmail.com>
AuthorDate: Sat Oct 17 12:25:00 2020 -0400
Commit:     markap14 <markap14@hotmail.com>
CommitDate: Mon Jan 4 14:20:05 2021 -0500

    NIFI-7937 Added StandardFlowFileMediaType enum to replace string
references to FlowFile Media Types



This is nice as it shows both who made the PR, who merged the PR, when the
PR was offered vs merged, etc.  And that works even if the commit
wasnt signed/signed off.

Thanks

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message