nutch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefan Groschupf (JIRA)" <j...@apache.org>
Subject [jira] Commented: (NUTCH-3) multi values of header discarded
Date Sat, 17 Dec 2005 16:58:34 GMT
    [ http://issues.apache.org/jira/browse/NUTCH-3?page=comments#action_12360667 ] 

Stefan Groschupf commented on NUTCH-3:
--------------------------------------

... the ideas was to leasve api as it is, just add a new getProperties method.
Should we now in general replace setProperty and getProperty with addProperty and getProperties
or  leave these for single property values? In case we leave set and get property should addProperty
than overwrite the  value setted with setProperty?
:-? 

> multi values of header discarded
> --------------------------------
>
>          Key: NUTCH-3
>          URL: http://issues.apache.org/jira/browse/NUTCH-3
>      Project: Nutch
>         Type: Bug
>     Reporter: Stefan Groschupf
>     Assignee: Stefan Groschupf
>      Fix For: 0.8-dev
>  Attachments: multiValuesPropertyPatch.txt
>
> orignal by: phoebe
> http://sourceforge.net/tracker/index.php?func=detail&aid=1111185&group_id=59548&atid=491356
> multi values of header discarded
> Each successive setting of a header value deletes the
> previous one.
> This patch allows multi values to be retained, such as
> cookies, using lf cr as a delimiter for each values.
> --- /tmp/HttpResponse.java 2005-01-27
> 19:57:55.000000000 -0500
> +++ HttpResponse.java 2005-01-27 20:45:01.000000000 -0500
> @@ -324,7 +324,19 @@
> }
> String value = line.substring(valueStart);
> - headers.put(key, value);
> +//Spec allows multiple values, such as Set-Cookie -
> using lf cr as delimiter
> + if ( headers.containsKey(key)) {
> + try {
> + Object obj= headers.get(key);
> + if ( obj != null) {
> + String oldvalue=
> headers.get(key).toString();
> + value = oldvalue +
> "\r\n" + value;
> + }
> + } catch (Exception e) {
> + e.printStackTrace();
> + }
> + }
> + headers.put(key, value);
> }
> private Map parseHeaders(PushbackInputStream in,
> StringBuffer line)
> @@ -399,5 +411,3 @@
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message