nutch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sami Siren (JIRA)" <j...@apache.org>
Subject [jira] Updated: (NUTCH-469) changes to geoPosition plugin to make it work on nutch 0.9
Date Wed, 09 May 2007 16:39:15 GMT

     [ https://issues.apache.org/jira/browse/NUTCH-469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sami Siren updated NUTCH-469:
-----------------------------

    Attachment: NUTCH-469-2007-05-09.txt.gz

tnahks for putting this together, I briefly checked through the .gz and patch

-please use diffs against trunk in future, they're more easy to check (svn diff > file)
-there is no junit tests at all, however there is tiny piece of test code in class GeoIndexingFilter,
atleast this code could perhaps be moved to a junit test class
-i replaced System.out.prints with logging statements
-i changed some formatting
-would it make sense to move the zip folder from conf to under plugins src/java and change
the load mechanism to use (context) class loader as i believe they are quite static piece
of information once generated?

I am attaching the patch is it is now

> changes to geoPosition plugin to make it work on nutch 0.9
> ----------------------------------------------------------
>
>                 Key: NUTCH-469
>                 URL: https://issues.apache.org/jira/browse/NUTCH-469
>             Project: Nutch
>          Issue Type: Improvement
>          Components: indexer, searcher
>    Affects Versions: 0.9.0
>            Reporter: Mike Schwartz
>             Fix For: 0.7.3
>
>         Attachments: geoPosition-0.5.tgz, geoPosition0.6_cdiff.zip, NUTCH-469-2007-05-09.txt.gz
>
>
> I have modified the geoPosition plugin (http://wiki.apache.org/nutch/GeoPosition) code
to work with nutch 0.9.  (The code was built originally using nutch 0.7.)  I'd like to contribute
my changes back to the nutch project.  I already communicated with the code's author (Matthias
Jaekle), and he agrees with my mods.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message