nutch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris A. Mattmann (JIRA)" <j...@apache.org>
Subject [jira] Commented: (NUTCH-485) Change HtmlParseFilter 's to return ParseResult object instead of Parse object
Date Sat, 16 Jun 2007 17:45:26 GMT

    [ https://issues.apache.org/jira/browse/NUTCH-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12505502
] 

Chris A. Mattmann commented on NUTCH-485:
-----------------------------------------

Doğacan, +1.

As for your question, IMO, these type of minor changes for formatting purposes are somewhat
unnecessary. However, if they are sparse, and really unnoticeable, I can say that I personally
wouldn't have an issue with them. I know some of the other folks who've been around longer
could probably provide some more guidance, however, again, my +1 for committing this.

> Change HtmlParseFilter 's to return ParseResult object instead of Parse object
> ------------------------------------------------------------------------------
>
>                 Key: NUTCH-485
>                 URL: https://issues.apache.org/jira/browse/NUTCH-485
>             Project: Nutch
>          Issue Type: Improvement
>          Components: fetcher
>    Affects Versions: 1.0.0
>         Environment: All
>            Reporter: Gal Nitzan
>            Assignee: Doğacan Güney
>             Fix For: 1.0.0
>
>         Attachments: NUTCH-485.200705122151.patch, NUTCH-485.200705130928.patch, NUTCH-485.200705130945.patch,
NUTCH-485.200705131241.patch, NUTCH-485.200705140001.patch
>
>
> The current implementation of HtmlParseFilters.java doesn't allow a filter to add parse
objects to the ParseResult object.
> A change to the HtmlParseFilter is needed which allows the filter to return ParseResult
. and ofcourse a change to  HtmlParseFilters .

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message