nutch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Julien Nioche (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NUTCH-1102) Fetcher, rely on fetcher.parse directive only
Date Tue, 06 Sep 2011 12:16:10 GMT

    [ https://issues.apache.org/jira/browse/NUTCH-1102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097948#comment-13097948
] 

Julien Nioche commented on NUTCH-1102:
--------------------------------------

@Markus : in the future maybe try and have a patch related to a given issue only? It does
not help reviewing otherwise + we might get confused as to which one is the correct one between
this and the one in NUTCH-1067 

Apart from that I don't mind if the command line option is removed as it can be specified
with '-D fetcher.parse=true' anyway, but we it should not be too difficult to fix it instead
so that we can use either. This would have the advantage of not forcing incompatible changes
to the users.

> Fetcher, rely on fetcher.parse directive only
> ---------------------------------------------
>
>                 Key: NUTCH-1102
>                 URL: https://issues.apache.org/jira/browse/NUTCH-1102
>             Project: Nutch
>          Issue Type: Bug
>          Components: fetcher
>    Affects Versions: 1.3
>            Reporter: Markus Jelsma
>            Assignee: Markus Jelsma
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: NUTCH-1102-1.4-1.patch
>
>
> The fetcher in 1.3 still has the -noParse option but does not do anything. A -parse switch
(NUTCH-872) is ignored, it seems my build wasn't messed up afterall. The fetcher.parse configuration
directive is also ignored. In short, Nutch 1.3 cannot parse fetched data immediately regardless
of configuration and options.
> How to procede? It makes little sense to have both the command option and the configuration
directive, it raises the question of authority and adds unnecessary confusion.
> I propose to get rid of the command option and rely on the configuration directive alone.
> Please comment.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message