nutch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lewis John McGibbney (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NUTCH-1274) Fix [cast] javac warnings
Date Sat, 12 Jan 2013 05:54:12 GMT

    [ https://issues.apache.org/jira/browse/NUTCH-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13551818#comment-13551818
] 

Lewis John McGibbney commented on NUTCH-1274:
---------------------------------------------

Hi Tejas, I'm working from 1.6 ish locally (I am just leaving for home just now). You are
correct, the nightly console output from Jenkins with Java 7 does in fact miss most of the
[cast]'s highlighted by Java 1.6. TestParserFactory still applies to the nightly build though.
In all honesty thanks for pointing out that different Java JDK's give different results with
regards to these messages, I didn't realise that this was the case.
Unless you wish to add to this, I am happy to commit with the TestParserFactory [cast]'s added
in. Same therefore applies to 2.x. Thank you.  
                
> Fix [cast] javac warnings
> -------------------------
>
>                 Key: NUTCH-1274
>                 URL: https://issues.apache.org/jira/browse/NUTCH-1274
>             Project: Nutch
>          Issue Type: Sub-task
>          Components: build
>    Affects Versions: nutchgora, 1.5
>            Reporter: Lewis John McGibbney
>            Assignee: Tejas Patil
>            Priority: Minor
>             Fix For: 1.7
>
>         Attachments: NUTCH-1274-2.x.patch, NUTCH-1274-trunk.patch
>
>
> A typical example of this is
> {code}
> trunk/src/java/org/apache/nutch/crawl/CrawlDatum.java:460: warning: [cast] redundant
cast to int
>     [javac]         res ^= (int)(signature[i] << 24 + signature[i+1] << 16
+ 
> {code}
> these should all be fixed by replacing with the correct implementations.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message