nutch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron Scheffel (JIRA)" <j...@apache.org>
Subject [jira] [Created] (NUTCH-1638) SolrWriter Bad String comparision
Date Mon, 09 Sep 2013 13:53:51 GMT
Aaron Scheffel created NUTCH-1638:
-------------------------------------

             Summary: SolrWriter Bad String comparision
                 Key: NUTCH-1638
                 URL: https://issues.apache.org/jira/browse/NUTCH-1638
             Project: Nutch
          Issue Type: Bug
          Components: indexer
    Affects Versions: 2.2.1, 1.7
            Reporter: Aaron Scheffel
            Priority: Minor


In version 2.2.1 and 1.7

Class org.apache.nutch.indexer.solr.SolrWriter

Line 66


inputDoc.addField(solrMapping.mapKey(e.getKey()), val2);

String sCopy = solrMapping.mapCopyKey(e.getKey());

if (sCopy != e.getKey()) {

inputDoc.addField(sCopy, val2);

}


There is a string comparison "sCopy != e.getKey()" with a != and not an
equals. It basically never works right. Not sure if someone was trying to
be clever but even if those strings are the same they happen to be
different objects. Which I'm assuming is due to how the strings are
serialized in from the config files.


Suggest its updated to


String sCopy = solrMapping.mapCopyKey(e.getKey());

if (!sCopy.equals(solrMapping.mapKey(e.getKey()))) {

       inputDoc.addField(sCopy, val2);

}


-Aaron


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message