nutch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron Scheffel (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (NUTCH-1638) SolrWriter Bad String comparision
Date Tue, 10 Sep 2013 11:51:52 GMT

    [ https://issues.apache.org/jira/browse/NUTCH-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13762975#comment-13762975
] 

Aaron Scheffel edited comment on NUTCH-1638 at 9/10/13 11:51 AM:
-----------------------------------------------------------------

So the comparison "sCopy != e.getKey()" always evaluates to true. The code "inputDoc.addField(sCopy,
val2);" always executes. So there is no need for the if statement if thats what you want to
do. 

A simple test would be to put a log statement above the if statement print the toString()
values of both strings then print the boolean result of a != of the two. You should be able
to see it.
                
      was (Author: ascheffe):
    I don't think you understand. I'm saying this expression "sCopy != e.getKey()" always
evaluates to true. So this code "inputDoc.addField(sCopy, val2);" always executes. There is
never an occurrence when it doesn't. So there is no need for the if statement if thats what
you want to do. 
                  
> SolrWriter Bad String comparision
> ---------------------------------
>
>                 Key: NUTCH-1638
>                 URL: https://issues.apache.org/jira/browse/NUTCH-1638
>             Project: Nutch
>          Issue Type: Bug
>          Components: indexer
>    Affects Versions: 1.7, 2.2.1
>            Reporter: Aaron Scheffel
>            Priority: Minor
>              Labels: patch
>         Attachments: NUTCH-1638.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> In version 2.2.1 and 1.7
> Class org.apache.nutch.indexer.solr.SolrWriter
> Line 66
> inputDoc.addField(solrMapping.mapKey(e.getKey()), val2);
> String sCopy = solrMapping.mapCopyKey(e.getKey());
> if (sCopy != e.getKey()) {
> inputDoc.addField(sCopy, val2);
> }
> There is a string comparison "sCopy != e.getKey()" with a != and not an
> equals. It basically never works right. Not sure if someone was trying to
> be clever but even if those strings are the same they happen to be
> different objects. Which I'm assuming is due to how the strings are
> serialized in from the config files.
> Suggest its updated to
> String sCopy = solrMapping.mapCopyKey(e.getKey());
> if (!sCopy.equals(solrMapping.mapKey(e.getKey()))) {
>        inputDoc.addField(sCopy, val2);
> }
> -Aaron

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message