nutch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Markus Jelsma (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NUTCH-1691) DomainBlacklist url filter does not allow -D filter file override
Date Thu, 02 Jan 2014 16:12:51 GMT

    [ https://issues.apache.org/jira/browse/NUTCH-1691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13860288#comment-13860288
] 

Markus Jelsma commented on NUTCH-1691:
--------------------------------------

Well, there is a small issue now:
{code}
WARN  domainblacklist.DomainBlacklistURLFilter - Attribute "file" is not defined in plugin.xml
for plugin urlfilter-domainblacklist
{code}

In my opinion we can remove the INFO and WARN code.

{code}
    if (attributeFile != null) {
      if (LOG.isInfoEnabled()) {
        LOG.info("Attribute \"file\" is defined for plugin " + pluginName
          + " as " + attributeFile);
      }
    }
    else {
      if (LOG.isWarnEnabled()) {
        LOG.warn("Attribute \"file\" is not defined in plugin.xml for plugin "
          + pluginName);
      }
    }

{code}

And only show an ERROR if there is are no rules to work with.

What do you think?

> DomainBlacklist url filter does not allow -D filter file override
> -----------------------------------------------------------------
>
>                 Key: NUTCH-1691
>                 URL: https://issues.apache.org/jira/browse/NUTCH-1691
>             Project: Nutch
>          Issue Type: Bug
>    Affects Versions: 1.7
>            Reporter: Markus Jelsma
>            Assignee: Markus Jelsma
>             Fix For: 1.8, 2.4
>
>         Attachments: NUTCH-1691-trunk.patch
>
>
> This filter does not accept -Durlfilter.domainblacklist.file= overrides. The plugin's
file attribute is always used.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message