nutch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alparslan Avcı (JIRA) <j...@apache.org>
Subject [jira] [Commented] (NUTCH-1714) Nutch 2.x upgrade to Gora 0.4
Date Tue, 13 May 2014 06:40:18 GMT

    [ https://issues.apache.org/jira/browse/NUTCH-1714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13996140#comment-13996140
] 

Alparslan Avcı commented on NUTCH-1714:
---------------------------------------

Hi [~lewismc],

bq. I am not particularly happy with this (and I am actively testing it so still have my own
comments to pass on) if you can suggest a better way to remove the Field at position 0 in
the array then we can go with that. I also don't really like the cast within the call to query.setFields.
WDYT?

I could not find the code that you have quoted in your comment, am I missing something? In
my patch, the removal of the Field at position 0 in the array is coded like this:
{code}
    String[] fields = Arrays.copyOfRange(WebPage._ALL_FIELDS, 1,
        WebPage._ALL_FIELDS.length);
    query.setFields(fields);
{code}
About this piece of code, actually I also think it is not a good solution. However; as it
is discussed in gora@dev mailing list, we should remove the first field from persistent class'
_ALL_FIELDS array and use the array directly. IMHO, we can use this temporary solution in
Nutch until the update of Gora.

Thanks!

> Nutch 2.x upgrade to Gora 0.4
> -----------------------------
>
>                 Key: NUTCH-1714
>                 URL: https://issues.apache.org/jira/browse/NUTCH-1714
>             Project: Nutch
>          Issue Type: Improvement
>            Reporter: Alparslan Avcı
>            Assignee: Alparslan Avcı
>             Fix For: 2.3
>
>         Attachments: NUTCH-1714.patch, NUTCH-1714_NUTCH-1714_v2_v3.patch, NUTCH-1714v2.patch,
NUTCH-1714v4.patch, NUTCH-1714v5.patch, NUTCH-1714v6.patch
>
>
> Nutch upgrade for GORA_94 branch has to be implemented. We can discuss the details in
this issue.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message