nutch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Markus Jelsma <markus.jel...@openindex.io>
Subject RE: Why is fetcher one big class?
Date Fri, 23 May 2014 08:16:37 GMT
Hi Diaa,

It would be a very good idea to have these classes split and make them 
pluggable. My biggest annoyance was/is every method and member being private 
and not protected.

Cheers,
Markus


-----Original message-----
From: Diaa Abdallah<diaa.abdelmoneim@gmail.com>
Sent: Thursday 22nd May 2014 23:43
To: dev@nutch.apache.org; user@nutch.apache.org
Subject: Why is fetcher one big class?

Currently the fetcher class is a 1,500 line piece of code.

Id like to suggest splitting it up to multiple files to improve readability and maintainability
of the code instead of this one big class with many nested classes.

The classes are grouped anyways by the fetcher namespace so having them all in one class doesnt
have a benefit in my opinion.

Do you think its a good idea to split up the fetcher class?

An example split would be:
Fetcher.java

FetchItem.java

FetchItemQueue.java

FetchItemQueues.java

QueueFeeder.java

FetcherThread.java

What do you think?

Regards,
Diaa



Mime
View raw message