From dev-return-26341-apmail-nutch-dev-archive=nutch.apache.org@nutch.apache.org Fri May 2 10:05:18 2014 Return-Path: X-Original-To: apmail-nutch-dev-archive@www.apache.org Delivered-To: apmail-nutch-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B553F10323 for ; Fri, 2 May 2014 10:05:18 +0000 (UTC) Received: (qmail 96375 invoked by uid 500); 2 May 2014 10:05:17 -0000 Delivered-To: apmail-nutch-dev-archive@nutch.apache.org Received: (qmail 96330 invoked by uid 500); 2 May 2014 10:05:16 -0000 Mailing-List: contact dev-help@nutch.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nutch.apache.org Delivered-To: mailing list dev@nutch.apache.org Received: (qmail 96308 invoked by uid 99); 2 May 2014 10:05:16 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 May 2014 10:05:16 +0000 Date: Fri, 2 May 2014 10:05:16 +0000 (UTC) From: =?utf-8?Q?Alparslan_Avc=C4=B1_=28JIRA=29?= To: dev@nutch.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (NUTCH-1714) Nutch 2.x upgrade to Gora 0.4 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/NUTCH-1714?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1398= 7551#comment-13987551 ]=20 Alparslan Avc=C4=B1 commented on NUTCH-1714: --------------------------------------- Hi [~jnioche], I do not know if you have tested the patch, but it fixes the problem with l= ast update. The reason for the _readdb_ problem is that it tries to get all= fields from _webpage_ table, and it uses _WebPage._ALL_FIELDS_ array to ac= hieve this. However, this array also contains ___g__dirty_ field which is u= sed to save dirty fields of the persistent class. This field is not stored = in database. Thus, when db is queried with this field, no results will be r= eturned.=20 In the patch I have removed ___g__dirty_ field directly from the fields sen= t to the query, since it is always at the first positon of the __ALL_FIELDS= _ array. This will fix the problem. However, I will also send a mail to dev= @gora and discuss if we should remove this field from persistent class' __A= LL_FIELDS_ array. Then, we can use _WebPage._ALL_FIELDS_ directly in here. Thanks for your comments. > Nutch 2.x upgrade to Gora 0.4 > ----------------------------- > > Key: NUTCH-1714 > URL: https://issues.apache.org/jira/browse/NUTCH-1714 > Project: Nutch > Issue Type: Improvement > Reporter: Alparslan Avc=C4=B1 > Assignee: Alparslan Avc=C4=B1 > Fix For: 2.3 > > Attachments: NUTCH-1714.patch, NUTCH-1714_NUTCH-1714_v2_v3.patch,= NUTCH-1714v2.patch, NUTCH-1714v4.patch, NUTCH-1714v5.patch > > > Nutch upgrade for GORA_94 branch has to be implemented. We can discuss th= e details in this issue. -- This message was sent by Atlassian JIRA (v6.2#6252)