nutch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebastian Nagel (JIRA)" <>
Subject [jira] [Updated] (NUTCH-1990) Use URI.normalise() in BasicURLNormalizer
Date Sun, 19 Apr 2015 21:18:58 GMT


Sebastian Nagel updated NUTCH-1990:
    Attachment: NUTCH-1990-trial1.patch

Sounds reasonable and would "en passant" resolve NUTCH-1062. But a trial (attached) was only
partially successful because URI.normalize() does not
- remove leading "/.." (should be definitely done according [RFC 3986, section 5.2.4, 2A|])
- add a "/" if path is/gets empty

After adding these two steps unit tests passed, except one which in fact was wrong before
("" should be normalized to "").
The patch is definitely not ready: the old version checks first whether there is a path element
to be normalized which can have massive performance impact.
In any case, we should compare old and new version regarding quality and performance with
a larger set of unnormalized outlinks.

> Use URI.normalise() in BasicURLNormalizer
> -----------------------------------------
>                 Key: NUTCH-1990
>                 URL:
>             Project: Nutch
>          Issue Type: Improvement
>    Affects Versions: 1.9
>            Reporter: Julien Nioche
>            Assignee: Julien Nioche
>         Attachments: NUTCH-1990-trial1.patch
> One of the things that [BasicURLNormalizer|]
is to remove unnecessary dot segments in path.
> Instead of implementing the logic ourselves with some antiquated regex library, we should
simply use [] which
does the same and is probably more efficient.

This message was sent by Atlassian JIRA

View raw message