nutch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris A. Mattmann (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (NUTCH-2072) Deflate encoding support is broken when http.content.limit is set to -1
Date Sun, 02 Aug 2015 23:40:04 GMT

    [ https://issues.apache.org/jira/browse/NUTCH-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14651279#comment-14651279
] 

Chris A. Mattmann edited comment on NUTCH-2072 at 8/2/15 11:39 PM:
-------------------------------------------------------------------

Fixed, thanks [~tanguy]!

{noformat}
[chipotle:~/tmp/nutch-trunk] mattmann% svn commit -m "Fix for NUTCH-2072: Deflate encoding
support is broken when http.content.limit is set to -1 contributed by Tanguy Moal <tanguy@cogniteev.com>
this closes #48."
Sending        CHANGES.txt
Sending        src/plugin/lib-http/src/java/org/apache/nutch/protocol/http/api/HttpBase.java
Transmitting file data ..
Committed revision 1693843.
[chipotle:~/tmp/nutch-trunk] mattmann% 
{noformat}



was (Author: chrismattmann):
Fixed, thanks [~ltanguy]

{noformat}
[chipotle:~/tmp/nutch-trunk] mattmann% svn commit -m "Fix for NUTCH-2072: Deflate encoding
support is broken when http.content.limit is set to -1 contributed by Tanguy Moal <tanguy@cogniteev.com>
this closes #48."
Sending        CHANGES.txt
Sending        src/plugin/lib-http/src/java/org/apache/nutch/protocol/http/api/HttpBase.java
Transmitting file data ..
Committed revision 1693843.
[chipotle:~/tmp/nutch-trunk] mattmann% 
{noformat}


> Deflate encoding support is broken when http.content.limit is set to -1
> -----------------------------------------------------------------------
>
>                 Key: NUTCH-2072
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2072
>             Project: Nutch
>          Issue Type: Bug
>          Components: plugin, protocol
>            Reporter: Tanguy Moal
>            Assignee: Chris A. Mattmann
>            Priority: Minor
>             Fix For: 1.11
>
>
> The method {{DeflateUtils.inflateBestEffort(byte[] in, int sizeLimit)}} is not designed
to have sizeLimit set to a negative value.
> The fix can be simply to mimic what's done with gzip encoding : if {{getMaxContent()
< 0}} then use {{Integer.MAX_VALUE}} for the {{sizeLimit}} argument.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message