nutch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jorgelbg <...@git.apache.org>
Subject [GitHub] nutch pull request: Adding a hashCode method to the Outlink class ...
Date Thu, 22 Oct 2015 16:21:55 GMT
GitHub user jorgelbg opened a pull request:

    https://github.com/apache/nutch/pull/79

    Adding a hashCode method to the Outlink class and a corresponding test

    The `Outlink` class doesn't have a `hashCode()` method. This doesn't cause any trouble
with the already implemented plugins but if a developer tries to use a `HashSet` of outlinks
in a custom plugin, the `Outlink` instances with same data (toUrl, anchor) gets added several
times. In contrast the `Inlink` class have a hashCode method. 
    
    https://github.com/apache/nutch/blob/trunk/src/java/org/apache/nutch/crawl/Inlink.java#L75-L77
    
    The same logic used in the `Inlink` class is implemented in this PR.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jorgelbg/nutch NUTCH-2146

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nutch/pull/79.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #79
    
----
commit bdc4d584cab4bd60b79ee3b4cea250d02709b77b
Author: Jorge Luis Betancourt <betancourt.jorge@gmail.com>
Date:   2015-10-19T01:09:14Z

    Adding a hashCode method to the Outlink class and a corresponding test

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message