nutch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lewismc <...@git.apache.org>
Subject [GitHub] nutch pull request: fix for NUTCH-2180 FileDumper skips Corrupt Se...
Date Thu, 10 Dec 2015 00:12:37 GMT
Github user lewismc commented on a diff in the pull request:

    https://github.com/apache/nutch/pull/85#discussion_r47173268
  
    --- Diff: src/java/org/apache/nutch/tools/FileDumper.java ---
    @@ -172,6 +172,11 @@ public boolean accept(File file) {
             }
           });
     
    +      if (partDirs == null) {
    +        LOG.warn("Skipping Corrupt Segment: [" + segment.getAbsolutePath() + "]");
    --- End diff --
    
    Note that this is not good syntax for slf4j. Line could be made much more performant by
using
    ```
    LOG.warn("Skipping Corrupt Segment: [{}]", segment.getAbsolutePath());
    ```
    I am +1 to merge this, I will make the change locally and commit. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message