nutch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lewismc <...@git.apache.org>
Subject [GitHub] nutch pull request: Add the boilerpipe parsing adapted from NUTCH-...
Date Sat, 27 Feb 2016 11:24:57 GMT
Github user lewismc commented on a diff in the pull request:

    https://github.com/apache/nutch/pull/92#discussion_r54332193
  
    --- Diff: src/plugin/parse-tika/src/java/org/apache/nutch/parse/tika/BoilerpipeExtractorRepository.java
---
    @@ -0,0 +1,62 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nutch.parse.tika;
    +
    +import java.lang.ClassLoader;
    +import java.lang.InstantiationException;
    +import java.util.WeakHashMap;
    +import org.apache.commons.logging.Log;
    +import org.apache.commons.logging.LogFactory;
    +import org.apache.tika.parser.html.BoilerpipeContentHandler;
    +import de.l3s.boilerpipe.BoilerpipeExtractor;
    +import de.l3s.boilerpipe.extractors.*;
    +
    +class BoilerpipeExtractorRepository {
    +
    +    public static final Log LOG = LogFactory.getLog(BoilerpipeExtractorRepository.class);
    +    public static final WeakHashMap<String, BoilerpipeExtractor> extractorRepository
= new WeakHashMap<String, BoilerpipeExtractor>();
    + 
    +    /**
    +     * Returns an instance of the specified extractor
    +     */
    +    public static BoilerpipeExtractor getExtractor(String boilerpipeExtractorName) {
    +      // Check if there's no instance of this extractor
    +      if (!extractorRepository.containsKey(boilerpipeExtractorName)) {
    +        // FQCN
    +        boilerpipeExtractorName = "de.l3s.boilerpipe.extractors." + boilerpipeExtractorName;
    +
    +        // Attempt to load the class
    +        try {
    +          ClassLoader loader = BoilerpipeExtractor.class.getClassLoader();
    +          Class extractorClass = loader.loadClass(boilerpipeExtractorName);
    +
    +          // Add an instance to the repository
    +          extractorRepository.put(boilerpipeExtractorName, (BoilerpipeExtractor)extractorClass.newInstance());
    +
    +        } catch (ClassNotFoundException e) {
    +          LOG.error("BoilerpipeExtractor " + boilerpipeExtractorName + " not found!");
    --- End diff --
    
    In slf4j we can better structure the catch
    http://www.slf4j.org/faq.html#logging_performance
    e.g.
    ```
    logger.debug("The entry is {}.", entry);
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message