nutch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NUTCH-2264) Check Forbidden API's at Build
Date Fri, 20 May 2016 00:49:13 GMT

    [ https://issues.apache.org/jira/browse/NUTCH-2264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15292473#comment-15292473
] 

ASF GitHub Bot commented on NUTCH-2264:
---------------------------------------

Github user kamaci commented on a diff in the pull request:

    https://github.com/apache/nutch/pull/115#discussion_r63977002
  
    --- Diff: build.xml ---
    @@ -1035,4 +1039,11 @@
           </classpath>
         </eclipse>
       </target>
    +
    +  <target name="check-forbidden-apis" depends="compile">
    +    <fa:forbiddenapis internalRuntimeForbidden="true" classpathref="classpath" dir="${build.dir}">
    +      <bundledsignatures name="jdk-unsafe-${javac.version}"/>
    --- End diff --
    
    Here is a list for what we can do: [(https://github.com/policeman-tools/forbidden-apis/wiki/BundledSignatures)]
On the other hand we can write some custom checks as like: [https://github.com/apache/lucene-solr/blob/master/lucene/tools/forbiddenApis/base.txt]


> Check Forbidden API's at Build
> ------------------------------
>
>                 Key: NUTCH-2264
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2264
>             Project: Nutch
>          Issue Type: Task
>    Affects Versions: 2.3.1
>            Reporter: Furkan KAMACI
>            Priority: Minor
>
> We should avoid [forbidden calls|https://github.com/policeman-tools/forbidden-apis/wiki]
 and check in the ant build for it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message