nutch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NUTCH-2285) Digest Authentication Support for REST API
Date Mon, 27 Jun 2016 18:29:52 GMT

    [ https://issues.apache.org/jira/browse/NUTCH-2285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351542#comment-15351542
] 

ASF GitHub Bot commented on NUTCH-2285:
---------------------------------------

Github user lewismc commented on a diff in the pull request:

    https://github.com/apache/nutch/pull/126#discussion_r68630240
  
    --- Diff: src/java/org/apache/nutch/api/NutchServer.java ---
    @@ -108,8 +118,41 @@ public NutchServer() {
         application.setStatusService(new ErrorStatusService());
         childContext.getAttributes().put(NUTCH_SERVER, this);
     
    -    // Attach the application.
    -    component.getDefaultHost().attach(application);
    +    AuthenticationTypeEnum authenticationType = configManager.get(ConfigResource.DEFAULT)
    +            .getEnum("restapi.auth", AuthenticationTypeEnum.NONE);
    +
    +    if (authenticationType == AuthenticationTypeEnum.NONE) {
    --- End diff --
    
    Please change to the more efficient switch notation. Multiple If's are messy and JDK1.8
has better switch support for string input values.


> Digest Authentication Support for REST API
> ------------------------------------------
>
>                 Key: NUTCH-2285
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2285
>             Project: Nutch
>          Issue Type: Sub-task
>          Components: REST_api, web gui
>            Reporter: Furkan KAMACI
>            Assignee: Furkan KAMACI
>             Fix For: 2.5
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message