nutch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NUTCH-2302) RAMConfManager Should Be Constructed With Custom Configuration
Date Sat, 20 Aug 2016 13:10:21 GMT

    [ https://issues.apache.org/jira/browse/NUTCH-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15429373#comment-15429373
] 

ASF GitHub Bot commented on NUTCH-2302:
---------------------------------------

GitHub user kamaci opened a pull request:

    https://github.com/apache/nutch/pull/143

    NUTCH-2302 RAMConfManager Should Be Constructed With Custom Configuration

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kamaci/nutch NUTCH-2302

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nutch/pull/143.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #143
    
----
commit d9d4e1fa77b3a9b10b7a78275ee6dc4bf0a136b8
Author: Furkan KAMACI <furkankamaci@gmail.com>
Date:   2016-08-20T13:08:47Z

    NUTCH-2302 RAMConfManager Should Be Constructed With Custom Configuration

----


> RAMConfManager Should Be Constructed With Custom Configuration 
> ---------------------------------------------------------------
>
>                 Key: NUTCH-2302
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2302
>             Project: Nutch
>          Issue Type: Improvement
>          Components: REST_api, web gui
>            Reporter: Furkan KAMACI
>            Assignee: Furkan KAMACI
>             Fix For: 2.4
>
>
> RAMConfManager is intented to hold different configurations which can be accessible via
a configuration id. However, it forces you to use a default configuration with a default id
when you construct it. When RAMConfManager is used by any other classes they cannot set a
custom configuration and it leads problem. i.e. test resources cannot be used when you test
NutchServer due to it uses default configuration which is forced by RAMConfManager.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message