nutch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebastian Nagel (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NUTCH-2320) URLFilterChecker to run as TCP Telnet service
Date Tue, 13 Dec 2016 09:39:58 GMT

    [ https://issues.apache.org/jira/browse/NUTCH-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15744691#comment-15744691
] 

Sebastian Nagel commented on NUTCH-2320:
----------------------------------------

Hi Markus,
generally +1 - the telnet service works and it's good to have it!

Wouldn't it be good to bundle the functionality shared by URLFilterChecker, URLNormalizerChecker
and IndexingFiltersChecker in a generic checker class and let all others inherit from it?
It's cleaner to avoid the duplications, and would make it easier to port the same functionality
to other "checkers" in the future.

Also two trivial improvements:
- could use {{StandardCharsets.UTF_8}} instead of {{Charset.forName("UTF-8")}}, no need to
catch exceptions (IllegalCharsetNameException or IllegalArgumentException)
- the code isn't formated via eclipse-codeformat.xml

> URLFilterChecker to run as TCP Telnet service
> ---------------------------------------------
>
>                 Key: NUTCH-2320
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2320
>             Project: Nutch
>          Issue Type: Improvement
>    Affects Versions: 1.12
>            Reporter: Markus Jelsma
>            Assignee: Markus Jelsma
>            Priority: Minor
>             Fix For: 1.13
>
>         Attachments: NUTCH-2320.patch, NUTCH-2320.patch
>
>
> Allow testing URL filters for webapplications just like indexing filters checker.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message