nutch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NUTCH-2376) Improve configurability of HTTP Accept* header fields
Date Thu, 20 Apr 2017 13:08:04 GMT

    [ https://issues.apache.org/jira/browse/NUTCH-2376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976653#comment-15976653
] 

ASF GitHub Bot commented on NUTCH-2376:
---------------------------------------

sebastian-nagel opened a new pull request #187: NUTCH-2376 Improve configurability of HTTP
Accept* header fields
URL: https://github.com/apache/nutch/pull/187
 
 
   - Accept, Accept-Language and Accept-Charset are configured and used the
     same way for both protocol-http and protocol-httpclient
   - a space as value will unset these header fields (not sent in request)
     I've tried to overwrite the default by an empty value but that's not possible with the
Hadoop configuration mechanism. Of course, one could configure instead `*` as "Accept-Language"
or "Accept-Charset" (resp. `*/*` as "Accept" content type) but that will unnecessarily blow
up the HTTP requests.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Improve configurability of HTTP Accept* header fields
> -----------------------------------------------------
>
>                 Key: NUTCH-2376
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2376
>             Project: Nutch
>          Issue Type: Improvement
>          Components: protocol
>    Affects Versions: 2.3.1, 1.13
>            Reporter: Sebastian Nagel
>            Priority: Minor
>
> There should be no differences between protocol-http and protocol-httpclient whether
the HTTP header fields {{Accept}}, {{Accept-Language}} and {{Accept-Charset}} are configurable.
The configured values should be used for both plugins. In addition,
> - it should be possible to unset the default values (overwrite with empty value) so that
no HTTP header field is sent
> - default values should be contained in nutch-default.xml
> Note: {{Accept-Encoding}} should not be configurable as the protocol plugins must support
the accepted compression codecs which may not be the case e.g. for Brotli.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message