nutch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NUTCH-2375) Upgrade the code base from org.apache.hadoop.mapred to org.apache.hadoop.mapreduce
Date Sat, 17 Jun 2017 19:43:00 GMT

    [ https://issues.apache.org/jira/browse/NUTCH-2375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16052966#comment-16052966
] 

ASF GitHub Bot commented on NUTCH-2375:
---------------------------------------

Omkar20895 commented on a change in pull request #188: NUTCH-2375 Upgrade the code base from
org.apache.hadoop.mapred to org.apache.hadoop.mapreduce
URL: https://github.com/apache/nutch/pull/188#discussion_r122575484
 
 

 ##########
 File path: src/java/org/apache/nutch/util/NutchJob.java
 ##########
 @@ -25,8 +25,9 @@
 /** A {@link Job} for Nutch jobs. */
 public class NutchJob extends Job {
 
-  public NutchJob(Configuration conf) throws IOException {
-    super(conf, "NutchJob");
-  }
+  public static NutchJob getJobInstance(Configuration conf){
 
 Review comment:
   This latest addition will still give error because we do not have an constructor in this
class and JVM will add a default constructor which will have a default super call to the parent
class. Something of this form : 
   ***default constructor***
   public NutchJob(){
     super()
   }
   
   But this won't create any discrepancy because we are not utilizing that default constructor
in the whole code base. 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Upgrade the code base from org.apache.hadoop.mapred to org.apache.hadoop.mapreduce
> ----------------------------------------------------------------------------------
>
>                 Key: NUTCH-2375
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2375
>             Project: Nutch
>          Issue Type: Improvement
>          Components: deployment
>            Reporter: Omkar Reddy
>
> Nutch is still using the deprecated org.apache.hadoop.mapred dependency which has been
deprecated. It need to be updated to org.apache.hadoop.mapreduce dependency. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message