nutch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NUTCH-2375) Upgrade the code base from org.apache.hadoop.mapred to org.apache.hadoop.mapreduce
Date Fri, 23 Jun 2017 11:22:00 GMT

    [ https://issues.apache.org/jira/browse/NUTCH-2375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16060751#comment-16060751
] 

ASF GitHub Bot commented on NUTCH-2375:
---------------------------------------

sebastian-nagel commented on issue #188: NUTCH-2375 Upgrade the code base from org.apache.hadoop.mapred
to org.apache.hadoop.mapreduce
URL: https://github.com/apache/nutch/pull/188#issuecomment-310639864
 
 
   Hi @Omkar20895, blindly catching exceptions (logging and throwing them again) does not
make the code better. It's important to think whether the exception needs to be handled or
not If the job job.waitForCompletion(true) throws an exception the job has failed
   - sometimes you need to clean up to avoid that long-living data structures (CrawlDb, LinkDb)
are broken, e.g. in [Injector](https://github.com/apache/nutch/blob/master/src/java/org/apache/nutch/crawl/Injector.java#L402)
   - for write-once structures (segments) this is usually not a requirement, as broken segments
are just ignored by other tools. In this case it's enough to throw the exception (it needs
to be declared to be thrown)
   
   Afaics, you're on the right way. Just make sure before a push that everything compiles
(`ant clean runtime javadoc test`).
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Upgrade the code base from org.apache.hadoop.mapred to org.apache.hadoop.mapreduce
> ----------------------------------------------------------------------------------
>
>                 Key: NUTCH-2375
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2375
>             Project: Nutch
>          Issue Type: Improvement
>          Components: deployment
>            Reporter: Omkar Reddy
>
> Nutch is still using the deprecated org.apache.hadoop.mapred dependency which has been
deprecated. It need to be updated to org.apache.hadoop.mapreduce dependency. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message