nutch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (NUTCH-2442) Injector to stop if job fails to avoid loss of CrawlDb
Date Mon, 06 Nov 2017 08:53:02 GMT


ASF GitHub Bot commented on NUTCH-2442:

sebastian-nagel commented on a change in pull request #239: NUTCH-2442 Injector to stop if
job fails to avoid loss of CrawlDb

 File path: src/java/org/apache/nutch/util/
 @@ -122,8 +122,17 @@ public int run(String[] args) throws Exception {
     try {
-      job.waitForCompletion(true);
-    } catch (Exception e) {
+      boolean success = job.waitForCompletion(true);
+      if(!success){
 Review comment:
   There is a missing space before opening brackets/braces (also other occurrences). The formatting
should follow the style defined by the Eclipse Code Formatter rules (
The easiest way is to import the rules into Eclipse (and other IDEs), in doubt, Eclipse allows
to format the code from the command-line.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Injector to stop if job fails to avoid loss of CrawlDb
> ------------------------------------------------------
>                 Key: NUTCH-2442
>                 URL:
>             Project: Nutch
>          Issue Type: Bug
>          Components: injector
>    Affects Versions: 1.13
>            Reporter: Sebastian Nagel
>            Priority: Critical
>             Fix For: 1.14
> Injector does not check whether the MapReduce job is successful. Even if the job fails
> - installs the CrawlDb
> -- move current/ to old/
> -- replace current/ with an empty or potentially incomplete version
> - exits with code 0 so that scripts running the crawl workflow cannot detect the failure
-- if Injector is run a second time the CrawlDb is lost (both current/ and old/ are empty
or corrupted)

This message was sent by Atlassian JIRA

View raw message