nutch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NUTCH-2450) Remove FixMe in ParseOutputFormat
Date Sun, 17 Dec 2017 15:40:00 GMT

    [ https://issues.apache.org/jira/browse/NUTCH-2450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16294200#comment-16294200
] 

ASF GitHub Bot commented on NUTCH-2450:
---------------------------------------

lewismc commented on issue #235: Fix for NUTCH-2450 by Kenneth McFarland
URL: https://github.com/apache/nutch/pull/235#issuecomment-352264301
 
 
   [TestURLUtil](https://github.com/apache/nutch/blob/master/src/test/org/apache/nutch/util/TestURLUtil.java)
testGetDomainDame() or additional tests for that test class.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Remove FixMe in ParseOutputFormat
> ---------------------------------
>
>                 Key: NUTCH-2450
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2450
>             Project: Nutch
>          Issue Type: Bug
>         Environment: master branch
>            Reporter: Kenneth McFarland
>            Assignee: Kenneth McFarland
>            Priority: Minor
>
> ParseOutputFormat contains a few FixMe's that I've looked at. If a valid url is created,
it will always return valid results. There is a spot in the code where the try catch is already
done, so the predicate is satisfied and there is no need to keep checking it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message