nutch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NUTCH-2460) use the headless option of firefox and chrome in protocol-selenium
Date Wed, 13 Dec 2017 20:23:00 GMT

    [ https://issues.apache.org/jira/browse/NUTCH-2460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16289820#comment-16289820
] 

ASF GitHub Bot commented on NUTCH-2460:
---------------------------------------

lewismc commented on a change in pull request #245: fix for NUTCH-2460 contributed by Hussein
Alahmad
URL: https://github.com/apache/nutch/pull/245#discussion_r156771769
 
 

 ##########
 File path: src/plugin/lib-selenium/src/java/org/apache/nutch/protocol/selenium/HttpWebClient.java
 ##########
 @@ -166,7 +175,7 @@ public static String getHTMLContent(WebDriver driver, Configuration conf)
{
   public static void cleanUpDriver(WebDriver driver) {
     if (driver != null) {
       try {
-	      driver.close();
+//	      driver.close();
 
 Review comment:
   @hussein-alahmad Why is this commented?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> use the headless option of firefox and chrome in protocol-selenium
> ------------------------------------------------------------------
>
>                 Key: NUTCH-2460
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2460
>             Project: Nutch
>          Issue Type: Improvement
>          Components: plugin, protocol
>            Reporter: hussein Al_Ahmad
>            Priority: Minor
>
> the --headless option is added to firefox in version 55 or later , and in chrome in version
59 or later ...
> this is much better than relying on  xvfb and its associates .
> we can add it as a property in the config file .
> I'm trying it on my local machine , and will create a pull request when I finish testing
it .



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message