nutch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NUTCH-2477) Refactor *Checker classes to use base class for common code
Date Sun, 17 Dec 2017 12:02:00 GMT

    [ https://issues.apache.org/jira/browse/NUTCH-2477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16294117#comment-16294117
] 

ASF GitHub Bot commented on NUTCH-2477:
---------------------------------------

sebastian-nagel commented on issue #256: fix for NUTCH-2477 (refactor checker classes) contributed
by Jurian Broertjes
URL: https://github.com/apache/nutch/pull/256#issuecomment-352250750
 
 
   +1
   
   Thanks, looks good to me. I'm going to commit this to 1.14.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Refactor *Checker classes to use base class for common code
> -----------------------------------------------------------
>
>                 Key: NUTCH-2477
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2477
>             Project: Nutch
>          Issue Type: Improvement
>    Affects Versions: 1.13
>            Reporter: Jurian Broertjes
>            Priority: Minor
>              Labels: pull-request-available
>
> The various Checker class implementations have quite a bit of duplicated code in them.
This should be refactored for cleanliness and maintainability.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message